emileclarkb/hammer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge remote-tracking branch 'upstream/master'

Browse source 
Conflicts:
	NOTES
This commit is contained in:
Dan Hirsch 2012-05-04 21:27:09 +01:00
commit d6c0eaf3de
3 changed files with 103 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

20
NOTES
View file

@ -15,6 +15,20 @@ consistency checks.
TODO: Add consistency check to the bitreader
We should support the use of parse-table-based parse methods; add a
parse_compile method that must be called before the newly-created
parser is used.
TODO: We should support the use of parse-table-based parse methods; add a
parse_compile method that must be called before the newly-created
parser is used.
Regarding butnot and difference:
There's a "do what I say, not what I do" variation in how we
implemented these (versus how jsparse did it). His `butnot` succeeds
if p1 and p2 both match and p1's result is longer than p2's, though
the comments say it should succeed if p2's result is longer than
p1's. Also, his `difference` succeeds if p1 and p2 both match, full
stop, returning the result of p2 if p2's result is shorter than p1's
or the result of p1 otherwise, though the comments say it should
succeed if p2's result is shorter than p1's. Whatever; we're doing
what the comments say.