emileclarkb/hammer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use Fixnum for Parser.ch()

Browse source
This commit is contained in:
Jakob Rath 2013-12-11 13:58:22 +01:00 • committed by Dan Hirsch
parent cfff00f8ed
commit 8048f2e731
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/bindings/ruby/lib/hammer/parser.rb
View file

@ -27,13 +27,9 @@ module Hammer
return parser return parser
end end
def self.ch(char) def self.ch(num)
# TODO: Really? Should probably accept Fixnum in appropriate range raise ArgumentError, 'expecting a Fixnum in 0..255', unless num.is_a?(Fixnum) and num.between?(0, 255)
# Also, char.ord gives unexpected results if you pass e.g. Japanese characters: '今'.ord == 20170; Hammer::Parser::Ch.new('今').parse(202.chr) == true h_parser = Hammer::Internal.h_ch(num)
# Not really unexpected though, since 20170 & 255 == 202.
# But probably it's better to use Ch for Fixnum in 0..255 only, and only Token for strings.
raise ArgumentError, 'expecting a one-character String' unless char.is_a?(String) && char.length == 1
h_parser = Hammer::Internal.h_ch(char.ord)
parser = Hammer::Parser.new parser = Hammer::Parser.new
parser.instance_variable_set :@h_parser, h_parser parser.instance_variable_set :@h_parser, h_parser